Skip to content

Fixed typos, added commas #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Fixed typos, added commas #2438

merged 3 commits into from
Aug 11, 2022

Conversation

kazanzhy
Copy link
Contributor

No description provided.

@kazanzhy kazanzhy marked this pull request as ready for review June 18, 2022 22:26
@julienrf
Copy link
Contributor

Thank you @kazanzhy.
Is there someone available to review the content?

@kazanzhy
Copy link
Contributor Author

I'll look for reviewers

@kazanzhy kazanzhy force-pushed the fix_typos branch 2 times, most recently from bc3442c to eceeda9 Compare June 22, 2022 21:01
@SethTisue
Copy link
Member

still needs a reviewer, and now also needs rebase

@SethTisue SethTisue marked this pull request as draft August 3, 2022 00:43
@kazanzhy
Copy link
Contributor Author

kazanzhy commented Aug 3, 2022

I rebased and pushed.
If you want I could close this PR

@SethTisue
Copy link
Member

SethTisue commented Aug 3, 2022

many of the changes you suggested here are good changes, but many are incorrect

(I assume you used some kind of automated tool?)

@kazanzhy
Copy link
Contributor Author

kazanzhy commented Aug 6, 2022

@SethTisue you're right I used the tool to check typos and it found a lot of them.
I just added some of than that seemed like real mistakes to me. I'm not a native speaker therefore I went too far :)

A lot of thanks for your time and help

@SethTisue SethTisue self-assigned this Aug 10, 2022
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're getting close — I've suggested a few further changes

Co-authored-by: SethTisue <seth@tisue.net>
Co-authored-by: SethTisue <seth@tisue.net>
@kazanzhy kazanzhy marked this pull request as ready for review August 11, 2022 21:31
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your patience in seeing this through to the end!

@SethTisue SethTisue merged commit ebfc251 into scala:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants